Re: [lwip-users] LWIP_RAND in dns.c

[Gennady Shmakov]

Krzysztof,

Both are defined little earlier in dns.c:

=================================

/* A list of DNS security features follows */

#define LWIP_DNS_SECURE_RAND_XID                1
#define LWIP_DNS_SECURE_NO_MULTIPLE_OUTSTANDING 2
#define LWIP_DNS_SECURE_RAND_SRC_PORT           4
/** Use all DNS security features by default.
 * This is overridable but should only be needed by very small targets
 * or when using against non standard DNS servers. */
#ifndef LWIP_DNS_SECURE
#define LWIP_DNS_SECURE (LWIP_DNS_SECURE_RAND_XID | LWIP_DNS_SECURE_NO_MULTIPLE_OUTSTANDING | LWIP_DNS_SECURE_RAND_SRC_PORT)
#endif

=================================

Simon,

Thanks for clarification. Does it make sense to move these defines in opt.h to avoid editing *.c files when these features are not needed?

#define LWIP_DNS_SECURE_RAND_XID                1
#define LWIP_DNS_SECURE_NO_MULTIPLE_OUTSTANDING 2
#define LWIP_DNS_SECURE_RAND_SRC_PORT           4

-----
Regards,
Gennady
mob. +7 985 8181210

On Thu, Oct 1, 2015 at 11:28 AM, Krzysztof Wesołowski <address@hidden> wrote:

#ifndef DNS_RAND_TXID
#if ((LWIP_DNS_SECURE & LWIP_DNS_SECURE_RAND_XID) != 0)
#define DNS_RAND_TXID LWIP_RAND

From reading code above I would guess it is required when both LWIP_DNS_SECURE & LWIP_DNS_SECURE_RAND_XID are defined, so why are you defining them?

Regards,
Krzysztof Wesołowski

_______________________________________________
lwip-users mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/lwip-users