Re: [lwip-users] Possible alignment bug in 1.4.0?

[address@hidden]

Mason wrote:
> Krzysztof Wesołowski wrote:
> > [..]
> > Assumes that&ethhdr->dest is 32bit aligned, which is true only for
> > ETH_PAD_SIZE==0.
> [..]
> In principle, you're right. If one defines ETH_PAD_SIZE to 2
> to align the IP header to 32 bits, then the first field of the
> Ethernet header (MAC dest) cannot be aligned to 32 bits.

I agree. While the default implementation of ETHADDR32_COPY() wouldn't 
fail, it's still questionable if it should be used here (when 
ETH_PAD_SIZE is != 0, at least). I'd have to take a look at the other 
usages of that macro, though, to be sure how it should be used...

Simon