[lwip-users] TCP_SND_QUEUELEN vs TCP_SNDQUEUELEN_OVERFLOW

[Art R.]

Greetings,

I was reading the current 1.3.0 release code and ran across something I find
puzzling.

tcp_out.c 
line 164-6: 
  queuelen = pcb->snd_queuelen;
  /* check for configured max queuelen and possible overflow */
  if ((queuelen >= TCP_SND_QUEUELEN) || (queuelen >
TCP_SNDQUEUELEN_OVERFLOW)) {

tcp.h
lines 333-334:
#define TCP_SNDQUEUELEN_OVERFLOW (0xffff-3)
  u16_t snd_queuelen; /* Available buffer space for sending (in tcp_segs).
*/

The default value for TCP_SND_QUEUELEN in opt.h is 8, if I read it
correctly. In our tests, it typically has values in the range of 20 or so.

The setting for TCP_SNDQUEUELEN_OVERFLOW is 65532  (FFFF-3).
It does not seem sensible to be comparing pcb->snd_queuelen to both
TCP_SND_QUEUELEN and TCP_SNDQUEUELEN_OVERFLOW.
Is this intended? A bug? What is the intended purpose for
TCP_SNDQUEUELEN_OVERFLOW?

HTH...

Art R.





-- 
View this message in context: 
http://www.nabble.com/TCP_SND_QUEUELEN-vs-TCP_SNDQUEUELEN_OVERFLOW-tp16291544p16291544.html
Sent from the lwip-users mailing list archive at Nabble.com.