[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-users] Bug in inet_chksum_pseudo() produces bad checksum(Parad
From: |
Kieran Mansley |
Subject: |
Re: [lwip-users] Bug in inet_chksum_pseudo() produces bad checksum(Paradigm C++) |
Date: |
Tue, 28 Aug 2007 09:21:47 +0100 |
On Tue, 2007-08-28 at 10:17 +1200, David Empson wrote:
> Performance issues aside, if I was reading code which did a "greater than
> zero" test I would immediately be wondering what was special about the value
> being negative, then discover the 'acc' variable was unsigned, then wonder
> why someone had written it using greater-than instead of not-equal.
>
> My opinion (for what it is worth) is that LWIP should stick with either the
> original form (number 1) or the more explicit form (number 2) which has
> already been checked in, but Dave should patch his own copy to work around
> the bug in his compiler.
I agree.
Kieran