lwip-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-users] ARP ETHARP_TRY_HARD


From: Leon Woestenberg
Subject: Re: [lwip-users] ARP ETHARP_TRY_HARD
Date: Tue, 30 Nov 2004 18:00:24 +0100
User-agent: Mozilla Thunderbird 0.7.1 (Windows/20040626)

Hello Paul,

Paul Clarke wrote:

Hi Leon,

I think you have made a typo
 /* no empty entry found and not allowed to recycle? */
 if ((empty == ARP_TABLE_SIZE) && ((flags & ETHARP_TRY_HARD) == 0))
        ^^^^^^ cvs has i

Whoops, introduced a (short-lived :-) bug.

I have made a patch with that and a couple of other changes move pbuf free to where it is needed (saves a ->p != NULL test) if the interface is not configured we must assume arp_input is for us.

Looks excellent except for the last change, for which I prefer your second method (in your follow-up email).
Thanks for the optimization.

BTW, we could use active developers with CVS write access. If you are interested, email me your Savannah
login.

Regards,

Leon Woestenberg.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]