[lwip-users] upd_new Bug

[Ralf]

Hello,

 

There is a small bug in upd_new (udp.c), if no memory is left (memp_malloc returns NULL) :

 

It is:

 

struct udp_pcb *
udp_new(void) {
  struct udp_pcb *pcb;
  pcb = memp_malloc(MEMP_UDP_PCB);
  /* could allocate UDP PCB? */
  if (pcb != NULL) {
    /* initialize PCB to all zeroes */
    memset(pcb, 0, sizeof(struct udp_pcb));
  }

 

  pcb->ttl = UDP_TTL;

 

  return pcb;
}

 

It should be:

 

struct udp_pcb *
udp_new(void) {
  struct udp_pcb *pcb;
  pcb = memp_malloc(MEMP_UDP_PCB);
  /* could allocate UDP PCB? */
  if (pcb != NULL) {
    /* initialize PCB to all zeroes */
    memset(pcb, 0, sizeof(struct udp_pcb));

    pcb->ttl = UDP_TTL;

  }

 

  return pcb;
}

 

 

 

Ralf