AW: [lwip-users] [PATCH] bunch of changes and new PPP for lwIP

[Zschocke, Florian]

Marc Boucher wrote on Montag, 3. Februar 2003 17:04:

> - major improvements to the socket code:
>       o support for non-blocking receives
[...]
>       o integrated select() support (improved version of davidhaas's
>       patch) 
>       o basic lwip_ioctl(), FIONREAD, get/setsockopt() etc. support 

I love these. :)

> - added additional argument to netif_add to pass state pointer
> so that the if_init function has access to context information
> before the interface is added, without accessing globals.
> 
> - added netif_remove()

Some comments on netif. Instead of having netif_add() allocate memory in the
lwIP memory space we would rather like to keep the netif structure in
different sections of our surrounding code. So I would suggest to either
a) Add another parameter to netif_add() passing it a pointer to a netif
structure. Only if this pointer is NULL will netif_add() allocate memory for
the netif structure, otherwise it will simply enqueue it. Some mechanism
would have to been developed for netif_remove to be able to tell if it is to
free the memory for the netif struct.

or b) seperate the addition of an netif into a netif_new() and
netif_enqueue() functions (and netif_dequeue() and netif_delete()
respectively) which can be called independantly.

> - added sys_sem_wait_timeout()

Very nice. :)

> - extended sys_thread_new() to return pid of created thread as
> sys_thread_t. 

Lovely.

I haven't looked at your code, yet, but I'm looking forward for these
changes to find their way into the CVS.

Florian.