[lwip-users] [lwip] Re: Out of order segment handling

[Kieran Mansley]

On Thu, 19 Sep 2002, Kieran Mansley wrote:
> There was another related bug in the out or order segment code that you
> might be interested in too.  In tcp_receive when out of order segments are
> checked and found to now be in order, they are chained to the recv_data.
> However, if recv_data is null this will segfault.  Changing it to:
>
>         if(cseg->p->tot_len > 0) {
>           /* Chain this pbuf onto the pbuf that we will pass to
>              the application. */
>           /* KJM added check on recv_data */
>           if(pcb->recv_data)
>             pbuf_chain(pcb->recv_data, cseg->p);
>           else
>             pcb->recv_data = cseg->p;
>           cseg->p = NULL;
>         }

This has already been done in the CVS version (should have checked before
posting, so not to worry.  The other behaviour of putting duplicate
segments on the out of order queue is still there though.

Kieran

[This message was sent through the lwip discussion list.]