[lwip-users] [lwip] Compiler Warning

[Martin Glunz]

Function do_close() inside api_msg.c:

  err_t err;
...
    case NETCONN_TCP:
      if(msg->conn->pcb.tcp->state == LISTEN) {
        err = tcp_close(msg->conn->pcb.tcp);
      }
      msg->conn->err = err;      
      break;
...

err is used unitialized here. Does it make sense to
initialize ther err variable:

  err_t err=ERR_OK;

or rather rearrange the code:

...
    case NETCONN_TCP:
      if(msg->conn->pcb.tcp->state == LISTEN) {
        err = tcp_close(msg->conn->pcb.tcp);
        msg->conn->err = err;      
      }
      break;
...
?


Martin Glunz
[This message was sent through the lwip discussion list.]