[lwip-users] [lwip] some fixes (compiler ambigiousness/errors/complaints/warnings) against CVS 2002-05-21

[leon . woestenberg]

Hello Adam,

while jumping to current CVS 2002-05-21, a few errors/warnings came up
using the Tasking EDE
compiler (v7.5r2) for the Infineon C166:

In tcp_input/tcp_input():

      /* Move this PCB to the front of the list so that subsequent
         lookups will be faster (we exploit locality in TCP segment
         arrivals). */
      if(prev != NULL) {

//      (struct tcp_pcb_listen *)prev->next = lpcb->next; // "= requires
modifiable value" error, I've got no idea why?

        ((struct tcp_pcb_listen *)prev)->next = lpcb->next; // LW: this
works

In tcp.h:

Had to add "U" to prevent signed/unsigned warnings later in the .c code:

#define TF_ACK_DELAY 0x01U   /* Delayed ACK. */
#define TF_ACK_NOW   0x02U   /* Immediate ACK. */

In inet.c:

Had to add "UL" to prevent signed/unsigned warnings:

      acc = (acc & 0xffffUL) + (acc >> 16);


I think adding these changes to the main tree would not break anyone else's
setup. It are
mainly "ambigious" issues where the compiler has too much freedom how to
interpret code.



Regards,

Leon.

[This message was sent through the lwip discussion list.]