[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-devel] [PATCH v2] PPP, PPPoE: Use service name and concentrato
From: |
goldsimon |
Subject: |
Re: [lwip-devel] [PATCH v2] PPP, PPPoE: Use service name and concentrator name |
Date: |
Thu, 20 Dec 2018 14:31:56 +0100 |
User-agent: |
K-9 Mail for Android |
Jacob Kroon wrote:
>Hi Sylvain,
>
>On Thu, Dec 20, 2018 at 2:23 PM Sylvain Rochet <address@hidden>
>wrote:
>>
>> Hi Jabob,
>>
>> On Thu, Dec 20, 2018 at 03:01:34AM +0100, Jacob Kroon wrote:
>> > * Make pppoe_create() actually store the passed service name and
>> > concentrator name, so that they are passed in the PADI/PADR/PADS
>packets
>> > * Assume that the user application won't be freeing the strings
>and
>> > just copy the string pointers, therefore remove the mem_free()
>in
>> > pppoe_destroy()
>> > * Since only the pointers are copied now, make them 'const' in
>pppoe_softc
>> > ---
>> > src/include/netif/ppp/pppoe.h | 4 ++--
>> > src/netif/ppp/pppoe.c | 15 ++++++---------
>> > 2 files changed, 8 insertions(+), 11 deletions(-)
>> >
>> > V2:
>> > Only copy the string pointers, not the contents, so remove
>freeing in
>> > pppoe_destroy() and make the pointers const
>>
>> Perfect, applied, thanks ! :)
>>
>
>No problem ! :-)
>Would it possible to get the PPPOE_SCNAME_SUPPORT merged to the 2.1.x
>branch ? If so, how would I proceed with that request ?
Request noted. I regularly cherry-pick commits from master. But I don't have a
schedule yet for the next 2.1.x release.
Regards,
Simon