[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9555] Add MDNS probing
|
From: |
Jens Nielsen |
|
Subject: |
[lwip-devel] [patch #9555] Add MDNS probing |
|
Date: |
Tue, 3 Jul 2018 06:16:07 -0400 (EDT) |
|
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36 |
Follow-up Comment #19, patch #9555 (project lwip):
Yes, sorry I meant to go through the code and remaining todos and do some
tests but I think it looks good. I'll open a new patch if I find something
useful to share.
The only minor comment from my side is that the two
LWIP_MIN(MDNS_LABEL_MAXLEN, len) added in
4506db4331ad1426e5589701d7b193a074aabfee should be unnecessary since there is
an LWIP_ERROR to return an error if len > MDNS_LABEL_MAXLEN? Or otherwise the
string null termination on the line below also needs LWIP_MIN
Anyway that's not important. Thanks a lot for the help Simon!
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?9555>
_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/