[lwip-devel] [patch #9579] unit: increase test timeout

[Joel Cunningham]

Follow-up Comment #2, patch #9579 (project lwip):

If anyone is interested, I figured out that check can write out the duration
of each test to an xml file. On my MacBook Air (core 2 duo from 2012) the
switch to memcpy reduced the duration from 2.335124s to 0.004089s, on my win10
box (core 2 duo from 2009) it is even slower.

I think the speed up is coming from not calling fail_unless on each byte. 
fail_unless is macro'd to ck_assert_msg, which calls _mark_point when the
assertion is true.

https://github.com/libcheck/check/blob/ed4f6d65024510131bbcf56eab88993986ba67ce/src/check.h.in#L484

It would be useful to always output the xml output when running
lwip_unittests.  Any thoughts?

For the Unix port, I have it writing lwip_unittests.xml in the same dir as the
lwip_unittest executable:


diff --git a/test/unit/lwip_unittests.c b/test/unit/lwip_unittests.c
index be74077..c33e9d6 100644
--- a/test/unit/lwip_unittests.c
+++ b/test/unit/lwip_unittests.c
@@ -86,6 +86,7 @@ int main(void)
 #endif
 
   sr = srunner_create((suites[0])());
+  srunner_set_xml(sr, "lwip_unittests.xml");
   for(i = 1; i < num; i++) {
     srunner_add_suite(sr, ((suite_getter_fn*)suites[i])());
   }


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9579>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/