[lwip-devel] [patch #9431] Removing the restriction on number of sockets

[Simon Goldschmidt]

Follow-up Comment #1, patch #9431 (project lwip):

The patch has some drawbacks:
- duplicated code in alloc_socket(): this is really bad as two #if/else blocks
do the same. A bug fixed in one bug can remain in the 2nd block. Never do
this!
- LWIP_SOCKET_OFFSET is not checked/obeyed everywhere
- alloc_socket() doesn't check for int overflow
- free_socket() doesn't follow our (old) C standard where variable
declarations and code must not be mixed
- Why is MEMP_MEM_MALLOC needed?

So far to the patch, I'll reply to the general discussion on the list.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9431>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/