Re: [lwip-devel] PPP: build failure due to redefinition of ‘struct vjstat’ if PPP_STATS_SUPPORT

[Axel Lin]

2017-04-13 9:23 GMT+08:00 Axel Lin <address@hidden>:
> Hi,
> I got below build error if #define PPP_STATS_SUPPORT 1.
>
> cc -g -Wall -DLWIP_DEBUG -pedantic -Werror -Wparentheses
> -Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow
> -Wpointer-arith -Wcast-qual -Wc++-compat -Wwrite-strings
> -Wold-style-definition -Wcast-align -Wmissing-prototypes
> -Wredundant-decls -Wnested-externs -Wno-address -Wunreachable-code
> -Wuninitialized -Wlogical-op -I. -I../../..
> -I../../../../lwip/src/include -I../../../ports/unix/port/include
> -I../../../../mbedtls/include -Wno-redundant-decls
> -DLWIP_HAVE_MBEDTLS=1 -c ../../../../lwip/src/core/init.c
> In file included from ../../../../lwip/src/core/init.c:62:0:
> ../../../../lwip/src/include/netif/ppp/ppp_impl.h:184:8: error:
> redefinition of ‘struct vjstat’
>  struct vjstat {
>         ^~~~~~
> In file included from ../../../../lwip/src/include/netif/ppp/ppp.h:188:0,
>                  from ../../../../lwip/src/include/netif/ppp/ppp_impl.h:53,
>                  from ../../../../lwip/src/core/init.c:62:
> ../../../../lwip/src/include/netif/ppp/vj.h:122:8: note: originally defined 
> here
>  struct vjstat {
>         ^~~~~~
> ../../Common.allports.mk:94: recipe for target 'init.o' failed
> make: *** [init.o] Error 1

BTW, if I set
#define VJ_SUPPORT              0
#define PPP_STATS_SUPPORT       1

I got another build error:

cc -g -Wall -DLWIP_DEBUG -pedantic -Werror -Wparentheses
-Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow
-Wpointer-arith -Wcast-qual -Wc++-compat -Wwrite-strings
-Wold-style-definition -Wcast-align -Wmissing-prototypes
-Wredundant-decls -Wnested-externs -Wno-address -Wunreachable-code
-Wuninitialized -Wlogical-op -I. -I../../..
-I../../../../lwip/src/include -I../../../ports/unix/port/include
-I../../../../mbedtls/include -Wno-redundant-decls
-DLWIP_HAVE_MBEDTLS=1 -c ../../../../lwip/src/netif/ppp/ipcp.c
../../../../lwip/src/netif/ppp/ipcp.c: In function ‘ipcp_up’:
../../../../lwip/src/netif/ppp/ipcp.c:2096:23: error: ‘fsm {aka struct
fsm}’ has no member named ‘unit’
     reset_link_stats(f->unit);
                       ^~
../../../../lwip/src/netif/ppp/ipcp.c: In function ‘ipcp_down’:
../../../../lwip/src/netif/ppp/ipcp.c:2129:24: error: ‘fsm {aka struct
fsm}’ has no member named ‘unit’
     update_link_stats(f->unit);
                        ^~
../../Common.allports.mk:94: recipe for target 'ipcp.o' failed
make: *** [ipcp.o] Error 1