[lwip-devel] [patch #9283] Returning access modes with fcntl

[Joan Lledó]

Follow-up Comment #9, patch #9283 (project lwip):

Hello Simon,

I've made some changes on the patch. Now it checks for null pointers and
returns O_RDWR for UDP and raw sockets. It also returns O_RDWR when both
O_RDONLY and O_WRONLY flags are set, because in some systems like Linux[1]
O_RDWR is not equal to O_RDONLY|O_WRONLY.

About the lock, I think I need your help here. The code doesn't make changes
on the socket, it only reads a flag from the pcb. And anyway, I read that it's
not supported that two threads work on the same socket at the same time.
What's the danger?

Thanks.

-----
[1] http://lxr.free-electrons.com/source/include/uapi/asm-generic/fcntl.h

(file #40182)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-lwip_fcntl-returns-access-modes.patch Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9283>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/