[lwip-devel] [patch #9139] Invalid format string in dhcp.c

[Thomas Mueller]

URL:
  <http://savannah.nongnu.org/patch/?9139>

                 Summary: Invalid format string in dhcp.c
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: tmu
            Submitted on: Mon 10 Oct 2016 07:39:20 AM GMT
                Category: DHCP
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

Some error messages passed in calls to LWIP_ERROR() in 
src/core/ipv4/dhcp.c attempting to print a percent sign
contain invalid conversion specifiers. When compiling
both LWIP_DEBUG and LWIP_NOASSERT defined, a compiler
validating format strings emits warnings/errors accordingly:


./lwip-dist/src/core/ipv4/dhcp.c: In function 'dhcp_parse_reply':
./lwip-dist/src/core/ipv4/dhcp.c:1522:20: error: unknown conversion type
character 0x20 in format [-Werror=format=]
         LWIP_ERROR("len % 4 == 0", len % 4 == 0, return ERR_VAL;);


The attached patch fixes this.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 10 Oct 2016 07:39:20 AM GMT  Name: dhcp-format.diff  Size: 1kB   By:
tmu

<http://savannah.nongnu.org/patch/download.php?file_id=38691>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9139>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/