[lwip-devel] [bug #44069] udp_sendto and similar don't accept const destination addresses

[chrysn]

URL:
  <http://savannah.nongnu.org/bugs/?44069>

                 Summary: udp_sendto and similar don't accept const
destination addresses
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: chrysn
            Submitted on: Thu 22 Jan 2015 17:25:48 GMT
                Category: UDP
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

functions like udp_sendto take address arguments which they
conceptionally won't modify, but do not declare them as const. this
causes issues with libraries like libcoap that treat their addresses,
which might be shared among different parts of the program, as const.

the attached patch is more a suggestion for discussion than a complete
solution, for once because it's atop DEVEL-1_4_1, and then because it is not
comprehensive (eg. tcp is not touched).

the only potential issue it shows is the api change in netif_output_fn --
while adding `const` to an api is usually not an issue, starting to require
`const` in the netif_output_fn  could be. the issue is mitigated by many
applications using etharp_output.

would a patch adding this more comprehensively on master be accepted?




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?44069>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/