Re: [lwip-devel] Does we have a plan that merge [ppp-new] to [master]?

[Ivan Delamer]

I'll give my 2 cents here too.

I've been using both ppp and ppp-new. I think there is a place for both
implementations, at least until ppp-new becomes a bit more mature.

I suggest adding a new folder, e.g. /lwip/netif/ppp4/ or
/lwip/netif/ppp-new/ , and perhaps a new configuration option such as
#define LWIP_PPP_NEW or similar. You can then control which stack is being
used through #include or makefile directives.

Switching branches is very easy in GIT, but it takes a lot of work to keep
the [ppp-new] branch up to date with the changes in [master]. Hence the
suggestion.

On another note, I have mixed feelings about the changed API. It would be
great to keep the old function prototypes for easy porting, on the other
hand it's good that they've changed because it forces you to revise your
ppp code. I'm not sure if it would be possible to define some
compatibility macros... I think I saw some in an earlier release.

Cheers
Ivan

PS: ppp-new has been running for a week here with no issues.


> Date: Tue, 21 Aug 2012 14:52:53 +0200
> From: "Simon Goldschmidt" <address@hidden>
> To: lwip-devel <address@hidden>
> Subject: Re: [lwip-devel] Does we have a plan that merge [ppp-new]    to
>       [master]?
> Message-ID: <address@hidden>
> Content-Type: text/plain; charset="utf-8"
>
> "Simon Goldschmidt" <address@hidden> wrote:
>> > >> Does we have a plan that merge [ppp-new] to [master]? I suggest to
>> do
>> this.
>> > >
>> > >No plan yet, but it will happen, probably after 1.4.1 is released.
>
> My 2 cents on this: could we first move/rename files in the current master
> and then merge ppp-new? That would make it easier to change between old
> and new ppp implementation: if someone is having problems with ppp-new, it
> would be easy to just fill in the latest version of the old ppp code when
> all file names are the same.
>
> Simon
>