[lwip-devel] [bug #30402] CHECKSUM_GEN_IP_INLINE does not add IP options

[Stephane Lesage]

URL:
  <http://savannah.nongnu.org/bugs/?30402>

                 Summary: CHECKSUM_GEN_IP_INLINE does not add IP options
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: slesage
            Submitted on: ven 09 jui 2010 23:39:32 CEST
                Category: IPv4
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:

Hi,

the new LWIP_INLINE_IP_CHKSUM defaults to 1, and with CHECKSUM_GEN_IP
enabled, CHECKSUM_GEN_IP_INLINE is enabled.

ip_output_if_opt() was working fine, but now the inline checksum generation
forgets to add the IP options.

I detected that using IGMP (we want IP_OPTIONS_SEND to add the Router Alert
option)

Here's a simple patch to add options to the checksum.

One might want to combine checksum and copy, but mixing with unaligned option
length is not trivial. Shall we force caller to use aligned options and ASSERT
?







    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: ven 09 jui 2010 23:39:32 CEST  Name: ip.c.patch  Size: 1 ko   By:
slesage

<http://savannah.nongnu.org/bugs/download.php?file_id=20933>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?30402>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/