lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #27352] Change ip_addr from struct to typedef (u32_t)


From: Bill Auerbach
Subject: [lwip-devel] [bug #27352] Change ip_addr from struct to typedef (u32_t)
Date: Tue, 18 May 2010 20:24:34 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 ( .NET CLR 3.5.30729)

Follow-up Comment #52, bug #27352 (project lwip):

I saw significant improvement packing by 2 over 1 before I found out that I
didn't need packing at all, which with no packing things were even better than
with packing by 2.  Packing by 2 at least allows the compiler to access the
ip_addr_t as 2 u16_t's over 4 u8_t's.  I would at least recommend default the
packing by 2 if it's used at all.

Perhaps a cc.h macro ALIGNMENT_REQUIRED can be added which allows lifting
alignment enforcing code and packing constructs when 0 and leaves the code in
to enforce it if 1.  IMO it's come up enough times and you've reviewed it and
put in sufficient time to warrant making it right for both conditions, don't
you?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?27352>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]