[lwip-devel] [bug #27352] Change ip_addr from struct to typedef (u32_t)

[Stephane Lesage]

Follow-up Comment #41, bug #27352 (project lwip):

Hi all,

I've prepared a patch that removes the packing constraint on struct _ip_addr.
Given that Simon already abstracted the ip_addr_t type, it will be very easy
to typedef it to u32_t.

What it does:
- include my previous patch for ip_addr_copy/ip_addr_set_safe
- copy before calling raw api callbacks
- copy before calling tcp_rst (maybe we could use the pcb addresses?)
- copy before calling a few other functions
- changed inet_chksum_pseudo to use u32_t as it's v4 specific, and it would
be silly to copy before, pass pointer and copy inside.

What it does not:
- solve the netbuf issue which stores a pointer inside the pbuf which may be
misaligned



(file #19698)
    _______________________________________________________

Additional Item Attachment:

File name: ip_addr_not_packed.patch       Size:36 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?27352>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/