[lwip-devel] [bug #28241] oos processing

[Simon Goldschmidt]

Update of bug #28241 (project lwip):

                  Status:                   Fixed => In Progress            
             Open/Closed:                  Closed => Open                   

    _______________________________________________________

Follow-up Comment #16:

Unfortunately, there's a bug in the patch from comment #14 which has made it
into the 1.3.2 release:

In tcp_in.c:tcp_receive(), line 1210 (and 1217 for the assertion), 

next->tcphdr->seqno

must be used instead of

pcb->ooseq->tcphdr->seqno

One could argue if this happens often (incoming segment being greater than
the first on ooseq and partly overlapping the second on ooseq) as most often,
retransmitted segments will be the same as before, so I don't know how serious
this bug is.

Still, running the corresponding unit test once showed that there was a
bug...

Oh, and about that "a bit hard to follow what it's changing and why": I'll
add some comments there, I think that's easier to read than the graphics.

I'll check it in but leave this open to discuss what to do about this bug
regarding the release.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?28241>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/