[lwip-devel] [patch #6965] PPP improvements

[Iordan Neshev]

Follow-up Comment #2, patch #6965 (project lwip):

Since the first post here (originally
sent to lwip-developers) is too long
and has many points to be discussed,
I decided to split it. I suggest to continue
to discuss what does not need much discussion.


srcnetifpppppp.c:
    * line 169: Jabobsen should be JaCobsen
    * line 312 and line 331: LWIP_UNUSED_ARG(pc) is missing
    * line 394: add a note above line 394
     /* Note: replace both NULLs with valid (pointers to)
      strings if you need to authorize with user name and
      password respectively and use the proper PPPAUTHTYPE_*/
   pppSetAuth(PPPAUTHTYPE_NONE, NULL, NULL);

    *line 525: add a note after lcp_init(pd);
    
    *line 564: replace
    if (pc->errCode) {pd = pc->errCode;} 
    else { pd = PPPERR_CONNECT; }
     with
     pd = (pc->errCode ? pc->errCode : PPPERR_CONNECT); /* use
     pd as return value */
         
    * line 660: replace
      if (pc->errCode) { pd = pc->errCode;} 
      else { pd = PPPERR_CONNECT; }
     with
     pd = (pc->errCode ? pc->errCode : PPPERR_CONNECT);


     *line 1325: this is now bug #27856

     *line 1388: add a call to netif_set_down() - not discussed
      here

     *line 1553: something tricky about ppp memory - this is
      bug #27079

srcnetifpppipcp.c:

  *line 192: add "static" in front of "char *_inet_ntoa(u32_t n)"

   * line 556: change the debug message by adding "UNHANDLED"
     FSMDEBUG((LOG_INFO, "%s: UNHANDLED Timeout event in state
     %d (%s)!n",


    *line 337: TCP_EVENT_RECV(pcb, NULL, ERR_OK, err);
       This is now bug #27851

srccoretcp_in.c
    *lines 690, 707, 718, 728: Add description in the debug
    messages what the current state is.

    *lines 814, 820: some more spaces. Seems like it's solved
      now.

srccoremem.c

     *line 175: add LWIP_HEAP_RAM_SECTION
       discussed in patch #6822


And, as Simon suggested:
     * make the PPP code use the common lwIP header structs.



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6965>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/