[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging
From: |
Bill Auerbach |
Subject: |
[lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd |
Date: |
Fri, 23 Oct 2009 16:16:52 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729) |
Follow-up Comment #4, bug #27445 (project lwip):
if ((u16_t)(pcb->cwnd + pcb->mss) > pcb->cwnd) { ... }
>From a coding standpoint, the 2 variables are u16_t and the cast has no
effect. From a runtime standpoint, is the cast always correct?
If the addition could overflow, the test fails. You should then cast to
u32_t. But I don't think those values can ever cause an overflow.
Maybe I'm picky - when I see a cast I think "we're changing what the compiler
will normally do". In this case we're not and at worse, could fail on an
overflow.
Bill
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?27445>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Kieran Mansley, 2009/10/15
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Simon Goldschmidt, 2009/10/16
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Kieran Mansley, 2009/10/23
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd,
Bill Auerbach <=
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Bill Auerbach, 2009/10/23
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Bill Auerbach, 2009/10/23
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Simon Goldschmidt, 2009/10/23
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Bill Auerbach, 2009/10/23
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Kieran Mansley, 2009/10/28
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Oleg Tyshev, 2009/10/29
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Kieran Mansley, 2009/10/29
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Kieran Mansley, 2009/10/29
- [lwip-devel] [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Oleg Tyshev, 2009/10/30
- [lwip-devel] Re: [bug #27445] PCB hangs in Fast Retransmit due to unchanging cwnd, Kieran Mansley, 2009/10/30