[lwip-devel] [bug #27709] conn->err race condition on netconn_recv() timeout

[Simon Goldschmidt]

Follow-up Comment #4, bug #27709 (project lwip):

> I don't think we've really fixed this - just made the race more unlikely.

I'm not sure there still is a race condition: The code now doesn't rely on
conn->err to be something specific, the only place where conn->err is checked
is to not overwrite another error (only write ERR_CLSD if it is ERR_OK
before). The original problem is thus solved.

However, I do agree that changing the API to let netconn_recv() return err_t
would be good. We should then also change the netconn functions to return an
err_t inside struct api_msg and we could eliminate conn->err totally.

I think we should find another way to solve the problems we tried to fix by
ERR_IS_FATAL(conn->err), e.g. test if a connection is opened before sending or
receiving.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?27709>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/