[lwip-devel] Possibly falsely triggered LWIP_ASSERT?

[Bill Auerbach]

In pbuf_realloc, the LWIP_ASSERT:

    LWIP_ASSERT("pbuf_realloc: q != NULL", q != NULL);

can be triggered falsely (or is it something prior that needs a check?).  I have a pbuf with no next.

p->tot_len is 1064

p->len is 46

p->next is NULL

new_len is 1028

grow is -36

so rem_len > q->len is true entering the while loop, but with q->next == NULL, it asserts.

The call came from ip_input.  iphdr_len is 1028.  Is this valid?  If not, should pbuf_realloc have even been called?

Bill