lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #26397] SLIP polling support


From: Kieran Mansley
Subject: [lwip-devel] [bug #26397] SLIP polling support
Date: Thu, 20 Aug 2009 14:03:22 +0000
User-agent: Opera/9.64 (X11; Linux i686; U; en) Presto/2.1.1

Follow-up Comment #2, bug #26397 (project lwip):

I don't think there's any particular reason why this has failed to be
applied, just that it hasn't been a high priority.

Looking at the patch, it seems to change a lot of code that isn't necessary
to add the slipif_poll() function.  If you could give more detail about the
need for the other changes (a good example is the change from sio_read to
sio_recv) that would help.  Some of the changes are obviously improvements and
bug fixes, but a lot aren't obvious at first glance to someone not familiar
with the sio code.

There also seem to be a lot of whitespace changes that make the patch a bit
harder to read: the whole copyright message for example shouldn't be in the
patch.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26397>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]