[lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window

[Simon Goldschmidt]

Follow-up Comment #20, bug #27209 (project lwip):

Reading the patch, I think we can drop the second "if
(TCPH_FLAGS(inseg.tcphdr) & TCP_FIN)" (inside the "else if
(TCP_SEQ_LEQ(pcb->ooseq->tcphdr->seqno, seqno + tcplen))" block) since the FIN
flag has already been checked above.

Also, I'd strongly encourage using braces for every if block (even if the
block is a single line) to prevent future developer's changes from forgetting
them when adding a line.

Last, only to make sure I understood the patch correctly, am I right that it
implements solution 2) of comment #9?

Unfortunately, I cannot really test the patch currently, but from reading,
the rest seems OK.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?27209>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/