lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Parad


From: Bill Auerbach
Subject: [lwip-devel] [patch #6699] Fixing a couple of compilation warnings(Paradigm C++)
Date: Mon, 22 Dec 2008 16:43:18 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5

Follow-up Comment #12, patch #6699 (project lwip):

>Do we need to remove that warning? 

On a compiler with sizeof int == 2, it's real.  The int can't be 0xFFFF. 
Sure, it's always false, but it's also bad coding style when it can be done
correctly for all platforms (which lwIP is quite good at).

>I believe the proper solution would be to use C99 types from stdint.h like
uint_fast16_t or equivalent.

That will break the code on many 8- and 16-bit compilers that are not C99
compatible.

Bill

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6699>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]