[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #24032] pbuf realloc wander over the end of a linked l
[lwip-devel] [bug #24032] pbuf realloc wander over the end of a linked list
Tue, 26 Aug 2008 19:24:22 +0000
Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9) Gecko/2008052906 Firefox/3.0
Follow-up Comment #2, bug #24032 (project lwip):
The second part of the patch (for pbuf_header) is simply wrong: you return 0
(= succeeded) when trying to take more of the pbuf than it has -> if anything,
returning 1 would be the right thing to do! (which is done by the LWIP_ERROR
you commented out)
As to the first part, of course Jonathan is right: this should never happen!
Nevertheless, ignoring this isn't good coding style - at least an assert
should be added which points you to the error instead of dereferencing a NULL
pointer (which I'll do now).
Reply to this item at:
Nachricht geschickt von/durch Savannah