[lwip-devel] [patch #6370] Sending to myself

[Jonathan Larmour]

Follow-up Comment #2, patch #6370 (project lwip):

After taking the approach of changing ip_route() there were some issues, but
you said these would be too invasive to fix. But I wouldn't have thought it
would be that invasive; or at least less so than the patch here. It seems not
very good to have so much new code here, especially since it's similar to
loopif.

Is having the source IP address set to 127.0.0.1 even a big issue?

Or even if ip_route() doesn't work so well I would have thought something
like this in ip_output_if() would do (similar to what you were already
proposing changing:

#if LWIP_HAVE_LOOPIF
  if (ip_addr_cmp(dest, &netif->ip_addr)) {

    /* Packet to self, enqueue it */

    LWIP_DEBUGF(IP_DEBUG, ("Passing to loopif"));



    return loopif_output(netif, p, dest);

  } else

#endif /* LWIP_HAVE_LOOPIF */

  {
    LWIP_DEBUGF(IP_DEBUG, ("netif->output()"));



    return netif->output(netif, p, dest);

  }

And make loopif_output no longer be static.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6370>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/