[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #21846] LwIP doesn't appear to perform any IP Source A
[lwip-devel] [bug #21846] LwIP doesn't appear to perform any IP Source Address Filtering
Wed, 19 Dec 2007 01:32:32 +0000
Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; MathPlayer 2.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Summary: LwIP doesn't appear to perform any IP Source
Project: lwIP - A Lightweight TCP/IP stack
Submitted by: tom_evans
Submitted on: Wednesday 12/19/2007 at 01:32
Severity: 3 - Normal
Item Group: None
Assigned to: None
Discussion Lock: Any
RFC1122 (October 1989):
"A host MUST silently discard an incoming datagram
containing an IP source address that is invalid by
the rules of this section. This validation could
be done in either the IP layer or by each protocol
in the transport layer."
By "this section" above they mean Multicast or Broadcast.
I can't find anything in ip.c that performs this check. There are no apparent
checks on the source address in there, udp.c or tcp_input.c.
The test might be as simple as the following, but I haven't checked this at
all, I'm assuming the broadcast test code is appropriate:
/* Broadcast or Multicast Source address, RFC 1122: 188.8.131.52 */
if ((ip_addr_isbroadcast(&(iphdr->src), inp)) ||
... debug print, free buffer, count stats, return ERR ...
It should probably go in ip.c after "#endif /* LWIP_DHCP */" as I think DHCP
can use strange source addresses.
Reply to this item at:
Message sent via/by Savannah
- [lwip-devel] [bug #21846] LwIP doesn't appear to perform any IP Source Address Filtering,
Tom Evans <=