[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [task #7142] Sanity check user-configurable values
From: |
Jonathan Larmour |
Subject: |
[lwip-devel] [task #7142] Sanity check user-configurable values |
Date: |
Thu, 30 Aug 2007 10:03:30 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060513 Fedora/1.0.8-1.1.fc3.1.legacy Firefox/1.0.8 |
Follow-up Comment #10, task #7142 (project lwip):
I don't see any reason to remove the "if (MEMP_NUM_TCP_SEG <
TCP_SND_QUEUELEN)" check. If someone has configured it that way, it's
definitely wrong. It doesn't matter that TCP_SND_QUEUELEN is for a single PCB
in that sense. For multiple PCBs the problem would be worse not better!
Thanks for changing the two I mentioned, although the tests should be ">=",
not just ">".
I'm happy for it to be checked in for other people to change (after these
little fixes). I can add more of the things from the initial post.
For the LWIP_DEBUG thing - LWIP_DEBUG is not on by default, so I don't think
it's true that new users will get these.
But if people decide they do want it to be a separate option, then only the
run-time checks need be conditionally compiled. The checks that can be done by
the preprocessor can stay in since in fact they will not be present if
unused.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/task/?7142>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [task #7142] Sanity check user-configurable values, Jonathan Larmour, 2007/08/02
- [lwip-devel] [task #7142] Sanity check user-configurable values, Jared Grubb, 2007/08/02
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/03
- [lwip-devel] [task #7142] Sanity check user-configurable values, Jonathan Larmour, 2007/08/03
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/15
- [lwip-devel] [task #7142] Sanity check user-configurable values, Kieran Mansley, 2007/08/29
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/29
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/29
- [lwip-devel] [task #7142] Sanity check user-configurable values, Jonathan Larmour, 2007/08/29
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/30
- [lwip-devel] [task #7142] Sanity check user-configurable values,
Jonathan Larmour <=
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/30
- [lwip-devel] [task #7142] Sanity check user-configurable values, Jared Grubb, 2007/08/30
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/30
- [lwip-devel] [task #7142] Sanity check user-configurable values, Jonathan Larmour, 2007/08/30
- [lwip-devel] [task #7142] Sanity check user-configurable values, Jared Grubb, 2007/08/30
- [lwip-devel] [task #7142] Sanity check user-configurable values, Jonathan Larmour, 2007/08/30
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/30
- [lwip-devel] [task #7142] Sanity check user-configurable values, Kieran Mansley, 2007/08/31
- [lwip-devel] [task #7142] Sanity check user-configurable values, Frédéric Bernon, 2007/08/31
- [lwip-devel] [task #7142] Sanity check user-configurable values, Kieran Mansley, 2007/08/31