RE : RE : RE : [lwip-devel] Last changes by Marc

[Frédéric BERNON]

2007-08-22 Frédéric Bernon

* tcpip.h, tcpip.c, ethernetif.c, opt.h: remove options ETHARP_TCPIP_INPUT &
  ETHARP_TCPIP_ETHINPUT, now, only "ethinput" code is supported, even if the 
  name is tcpip_input (we keep the name of 1.2.0 function).

Finally, this patch cause some problems (for loopif with 
LWIP_LOOPIF_MULTITHREADING=1). I open a bug record for that... 
  
====================================
Frédéric BERNON 
HYMATOM SA 
Chef de projet informatique 
Microsoft Certified Professional 
Tél. : +33 (0)4-67-87-61-10 
Fax. : +33 (0)4-67-70-85-44 
Email : address@hidden 
Web Site : http://www.hymatom.fr 
====================================
P Avant d'imprimer, penser à l'environnement
 


-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Jonathan Larmour
Envoyé : mardi 21 août 2007 16:24
À : lwip-devel
Objet : Re: RE : RE : [lwip-devel] Last changes by Marc


Frédéric BERNON wrote:
>> I had thought you had meant make it only the ETHARP_TCPIP_ETHINPUT 
>> option,
>> rather than make it no option at all. Not everyone uses ethernet, and 
>> there may be other routes for drivers to introduce packets to the system 
>> (e.g. via their own tcpip_callback calls, like PPP does), so it should 
>> still be an option I think. Not least if anyone was using only PPP, not 
>> ethernet.
> 
> Ok. So, which option? I think that LWIP_ARP should be enought and 
> avoid to (re-)add something like ETHARP_TCPIP_ETHINPUT or 
> ETHARP_TCPIP_INPUT. Your point of view?

I guess since for now at least LWIP_ARP is specific to ethernet, then yes 
changing the #if ETHARP_TCPIP_ETHINPUT code to be LWIP_ARP would be fine 
for me. And remove the ETHARP_TCPIP_INPUT specific code, as you wanted.

Jifl
-- 
eCosCentric Limited      http://www.eCosCentric.com/     The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK.       Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["The best things in life aren't things."]------      Opinions==mine


_______________________________________________
lwip-devel mailing list
address@hidden http://lists.nongnu.org/mailman/listinfo/lwip-devel

Frédéric BERNON.vcf
Description: Frédéric BERNON.vcf