[lwip-devel] [task #7136] Centralize mempool settings in separate file

[Jared Grubb]

Follow-up Comment #13, task #7136 (project lwip):

I personally like seeing an explicit list of what the mempools are. But, you
do bring up a valid argument: what happens if the user does minimal
configuration. All the defaults should "just work" for the user. Also, if a
new feature is added into CVS that requires a change to the lwippools.h, but
the file is exclusively in the user's domain, then we have a maintanence
issue.

If we leave the MEMP_NUM_* options in place, then I would suggest pulling out
the standard pools into a lwip/include/memp_std.h file.  Then we create two
new options:
* MEMP_USE_STD_POOLS (default 1) to give the user an ability to disable all
the standard pools and explicitly make them himself
* MEMP_USE_CUSTOM_POOLS (default 0) to indicate that he wants to add custom
pools to the list (e.g., the mem_malloc pools)
If MEMP_USE_STD_POOLS==0 or MEMP_USE_CUSTOM_POOLS==1, then the lwippools.h
file will be included.

As far as dependencies and checking, I think that would be a great idea. We
could create a header file whose sole job is to do all the sanity checks on
options that we might want.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7136>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/