[lwip-devel] [patch #5904] etharp.h: define ETH_PAD_SIZE after including opt.h

[Simon Goldschmidt]

URL:
  <http://savannah.nongnu.org/patch/?5904>

                 Summary: etharp.h: define ETH_PAD_SIZE after including opt.h
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Sonntag 29.04.2007 um 17:03
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I remember reading this somewhere already, but I think it was lwip_users and
no change was made:

In etharp.h, ETH_PAD_SIZE is defined:
#ifndef ETH_PAD_SIZE
#define ETH_PAD_SIZE 0
#endif

before _any_ file is included, resulting in ETH_PAD_SIZE always = 0. This is
currently no big issue since opt.h seems to be included everywhere before
etharp.h is included. Still it could become a problem.

I propose moving the above code below all includes and adding #include
"lwip/opt.h" at the top of the file.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sonntag 29.04.2007 um 17:03  Name: etharp.h_ETH_PAD_SIZE.patch  Size:
687B   By: goldsimon

<http://savannah.nongnu.org/patch/download.php?file_id=12621>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5904>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/