[lwip-devel] [bug #19432] netbuf_ref doesn't check pbuf_alloc result

[Frédéric Bernon]

URL:
  <http://savannah.nongnu.org/bugs/?19432>

                 Summary: netbuf_ref doesn't check pbuf_alloc result
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: fbernon
            Submitted on: mercredi 28.03.2007 à 11:10
                Category: None
                Severity: 3 - Normal
              Item Group: Crash Error
                  Status: None
                 Privacy: Public
             Assigned to: fbernon
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

In netbuf_ref, pbuf_alloc result is not tested. A check and a return value
can be add...

err_t
netbuf_ref(struct netbuf buf, const void dataptr, u16_t size)
{ if (buf->p != NULL) {
    pbuf_free(buf->p);
  }
  buf->ptr = buf->p = NULL;
  buf->p = pbuf_alloc(PBUF_TRANSPORT, 0, PBUF_REF);
  if (buf->p == NULL) {
    return ERR_MEM;
  }
  buf->p->payload = (void*)dataptr;
  buf->p->len = buf->p->tot_len = size;
  buf->ptr = buf->p;
  return ERR_OK;
} 





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19432>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/