[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master
From: |
Joel Cunningham |
Subject: |
Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-736-g10a5afe |
Date: |
Thu, 22 Jun 2017 00:52:08 -0500 |
Dirk,
One way I thought we can implement tcpip_callback so that the function is not
executed immediately for the core locking case would be to add the
tcpip_callback_fn to a delayed queue and then execute the queued functions
during UNLOCK_TCPIP_CORE. This would ensure the callback function is executed
after the current core lock critical section is complete without having to
context switch to the TCP/IP thread
One area that would benefit from this is the loopback netif output where we
can't currently call back into the stack (for the core locking case) during the
current output because of reentrancy problems in the TCP layer
Joel
> On Jun 21, 2017, at 08:07, Dirk Ziegelmeier <address@hidden> wrote:
>
> This is an automated email from the git hooks/post-receive script. It was
> generated because a ref change was pushed to the repository containing
> the project "lwIP - A Lightweight TCPIP stack".
>
> The branch, master has been updated
> via 10a5afeee7fdfd780452034860d4c1c42ead4228 (commit)
> from 68d36f19f0365f0d58b9b12c5748aeac2700b9d1 (commit)
>
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email; so we list those
> revisions in full, below.
>
> - Log -----------------------------------------------------------------
> commit 10a5afeee7fdfd780452034860d4c1c42ead4228
> Author: Dirk Ziegelmeier <address@hidden>
> Date: Wed Jun 21 15:07:20 2017 +0200
>
> Revert my last change to tcpip_callback() - it breaks the semantics of the
> function.
> The function previously returned after posting a message, which is a short
> operation. Now it actually waits until the operation has completed - which
> may take a long time. This may break user programs. So all that remains is
> the cleanup separation in tcpip_callback() and tcpip_try_callback() :-(
>
> -----------------------------------------------------------------------
>
> Summary of changes:
> src/api/tcpip.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
>
> hooks/post-receive
> --
> lwIP - A Lightweight TCPIP stack
>
> _______________________________________________
> lwip-commits mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/lwip-commits