Re: [lmi] wxPdfDoc: autoreconf failing with cygwin

[Greg Chicares]

On 2018-08-09 09:14, Vadim Zeitlin wrote:
> On Wed, 8 Aug 2018 17:16:54 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> Vadim--You probably don't have time to fix this properly right now,
> 
>  Unfortunately you're right, I don't have Cygwin here and so I can't
> reproduce the problem.
> 
> GC> but in the meantime can you think of any kludge that might get us
> GC> past this problem quickly so that we can start final testing of the
> GC> PDF code you've modernized?
> GC> 
> GC> This happens on an msw-10 machine, on which cygwin was installed
> GC> today using 'install_cygwin.bat'.
> GC> 
> GC> cd /opt/lmi/wxpdfdoc-scratch/wxPdfDoc-v0.9.6-28-gf66b428 \
> GC>   && export PATH="/MinGW_/bin/:/usr/local/bin:/usr/bin:[...tons of 
> corporate clutter removed...]" \
> GC>   && autoreconf \
> GC>   && ./configure --prefix=/opt/lmi/local --exec-prefix=/opt/lmi/local 
> --with-wx-prefix=/opt/lmi/local --with-wx-exec-prefix=/opt/lmi/local 
> --build=i686-pc-cygwin --host=i686-w64-mingw32 --disable-dependency-tracking 
> CFLAGS='-fno-omit-frame-pointer' CXXFLAGS='-fno-omit-frame-pointer 
> -std=c++11'  \
> GC>   && make install \
> GC> 
> GC> configure.ac:46: error: possibly undefined macro: AC_MSG_FAILURE
> GC>       If this token and others are legitimate, please use 
> m4_pattern_allow.
> GC>       See the Autoconf documentation.
> GC> autoreconf-2.69: /usr/bin/autoconf-2.69 failed with exit status: 1
> 
>  I can think of a few things to do here:
> 
> - It could make sense to avoid running autoreconf under Cygwin in the
>   first place and just use the pregenerated (under Linux) configure script
>   there. If you'd like to do this, please apply the following patch:

Okay, that workaround did enable us to build wxPdfDoc in the office,
but it seems inappropriate to commit it to the public repository...

> ---------------------------------- 8< ----------------------------------
> diff --git a/install_wxpdfdoc.make b/install_wxpdfdoc.make
> index d0f18ae97..09e1d335b 100644
> --- a/install_wxpdfdoc.make
> +++ b/install_wxpdfdoc.make
> @@ -38,7 +38,7 @@ wxpdfdoc_dir  := /opt/lmi/wxpdfdoc-scratch
>  # archive name because we don't want to use the bare commit SHA-1 as the file
>  # name, so we need a separate "urlbase" variable.
>  
> -wxpdfdoc_commit             := f66b42805a7262cdf07ab04a4e20b252b5d81ddb
> +wxpdfdoc_commit             := 1223f6e6449e0ae211e8cc473d0b0c6bd06e8951
>  wxpdfdoc_archive            := wxpdfdoc-$(wxpdfdoc_commit).zip
>  $(wxpdfdoc_archive)-urlbase := $(wxpdfdoc_commit).zip
>  $(wxpdfdoc_archive)-root    := https://github.com/vadz/wxpdfdoc/archive
> @@ -115,7 +115,6 @@ WGETFLAGS :=
>  wxpdfdoc: $(wxpdfdoc_archive)
>         cd $(source_dir) \
>           && export PATH="$(mingw_bin_dir):${PATH}" \
> -         && autoreconf \
>           && ./configure $(config_options) \
>           && $(MAKE) install \
>  
> ---------------------------------- 8< ----------------------------------

...because AIUI
> -         && autoreconf \
simply sidesteps the problem.

>   The only difference between the old and the new commit is that I've
>   added the generated files to the repository in it.

But doesn't that introduce a fragile dependency on your performing
an extra step manually?

> - If you'd like to continue building from "pristine" sources, we need

That's what we do for every other library IIRC, so I think the wxPdfDoc
build process should be equally robust.

>   to fix the real error which could, AFAICS, be due to either:
> 
>   + Overquoting of autoconf macros. I've tried to blindly fix this with
[...]
>   + Missing definition for PKG_CHECK_MODULES() which contain another
[...]
>  Please let me know if either of these suggestions helps. I'm almost
> certain that the first one should, so if you really just want to fix the
> problem a.s.a.p., it would be the one to try. But if you'd like to find the
> real reason of the problem, then it would be worth to test the other two
> fixes.

With all that's going on in the office right now, we aren't going to
be able to do this ourselves. Now that you're no longer on the road,
could I ask you to find and fix the underlying problem? Actually, if
you're looking for more things to do, it would be immensely helpful
if you could do the following in a cygwin environment:

  ./nychthemeral_test.sh 2>&1 | tee /tmp/lmi/logs/log | sed -f errors.sed

and figure out how to fix the problems, which begin with (but are
probably not limited to):

grep: (standard input): Invalid argument
grep: (standard input): Invalid argument
grep: (standard input): Invalid argument
0 tests succeeded

And if you're looking for even more things to do, it would be
really nice to modernize lmi's wxPdfDoc installer along the lines
of the improvements you made to the wxWidgets install script.