Re: [lmi] [lmi-commits] master 43dcd1b 5/6: Make all table_column_info data members private and non-const

[Vadim Zeitlin]

On Thu, 23 Aug 2018 19:59:30 -0400 (EDT) Greg Chicares <address@hidden> wrote:

GC> branch: master
GC> commit 43dcd1b788a27f55c67de39c07e62d6fce781ca2
GC> Author: Gregory W. Chicares <address@hidden>
GC> Commit: Gregory W. Chicares <address@hidden>
GC> 
GC>     Make all table_column_info data members private and non-const
GC>     
GC>     It is impossible to change members' values after construction, so there
GC>     is no longer any need for them to be const; and their constness was a
GC>     problem because it made the class nonassignable.

 I don't really understand why the fields shouldn't be const if it's
impossible to change them: IMHO this is exactly the reason to make them
const.

 And are you sure that this class should be assignable? I think being
movable should be enough.

VZ