Re: [lmi] First version of the illustrations pagination patch

[Greg Chicares]

On 2018-07-17 21:14, Greg Chicares wrote:
> On 2018-06-23 21:35, Vadim Zeitlin wrote:
>> 
>>  Here is the long-promised version of the pagination patch:
>> 
>>              https://github.com/vadz/lmi/pull/86
> 
> To reproduce an anomaly with HEAD + PR 86:

To reproduce a different anomaly:

  File | New | Census
  Census | Edit case defaults...
    [tab names given for 'skin.xrc']
    "Plan" tab: change product to 'sample2quo'--see:
      https://lists.nongnu.org/archive/html/lmi/2018-07/msg00019.html
    "Names" tab: change corporation name to any nonempty string
      [otherwise group quotes are forbidden]
    "Face" tab: change "Supplemental amount" to 200000
  OK
  Yes to apply...
  Census | Print group premium quote to PDF

Not enough space for all 10 columns.
Printable width is 756 points.
Data alone require 611 points without any margins for legibility.
Column margins of 8 points on both sides would take up 160 additional points.
[wx_table_generator.cpp : 661]
  ...followed by...
Assertion '0 <= ci.col_width - column_margin()' failed.
[wx_table_generator.cpp : 756]

[Perhaps this problem stems from font-size changes here:
  
https://github.com/vadz/lmi/pull/86/commits/8ddbdc5a1d3d5122960521e58f34891f08e4c5dd
but I haven't yet tried reverting that commit.]

If we suppress that failing assertion and instead force the clipping
region's width to be nonnegative, thus:

    ,wxSize{std::max(0, ci.col_width() - column_margin()), row_height_}

then the problem reported here:
  https://lists.nongnu.org/archive/html/lmi/2018-07/msg00017.html
  Assertion 'height <= get_total_height() - y' failed.
occurs again.