Re: [lmi] [lmi-commits] master bbcdaf5 1/2: Update commentary

[Vadim Zeitlin]

On Mon,  4 Jun 2018 19:11:49 -0400 (EDT) Greg Chicares <address@hidden> wrote:

GC> branch: master
GC> commit bbcdaf540882fd8947381904ceb31ea25f458c97
GC> Author: Gregory W. Chicares <address@hidden>
GC> Commit: Gregory W. Chicares <address@hidden>
GC> 
GC>     Update commentary
GC> ---
GC>  actuarial_table.cpp | 4 ++--
GC>  1 file changed, 2 insertions(+), 2 deletions(-)
GC> 
GC> diff --git a/actuarial_table.cpp b/actuarial_table.cpp
GC> index ce11e3a..17bf1c0 100644
GC> --- a/actuarial_table.cpp
GC> +++ b/actuarial_table.cpp
GC> @@ -280,7 +280,7 @@ void actuarial_table::find_table()
GC>  /// The record types of interest here are coded as:
GC>  ///   9999 end of table
GC>  ///   2    4-byte integer:  Table number
GC> -///   3    [unsigned] char: Table type: {A, D, S} --> {age, duration, 
select}
GC> +///   3    1-byte char   :  Table type: {A, D, S} --> {age, duration, 
select}
GC>  ///   12   2-byte integer:  Minimum age
GC>  ///   13   2-byte integer:  Maximum age
GC>  ///   14   2-byte integer:  Select period
GC> @@ -328,7 +328,7 @@ void actuarial_table::parse_table()
GC>                  LMI_ASSERT(z == table_number_);
GC>                  }
GC>                  break;
GC> -            case 3: // [unsigned] char: Table type.
GC> +            case 3: // char: Table type.
GC>                  {
GC>                  // Meaning: {A, D, S} --> {age, duration, select}.
GC>                  // SOA apparently permits upper or lower case.

 This is pretty minor, but I think this change is not right: in this case,
it's really a byte, i.e. an unsigned char. We don't perform any arithmetic
operations on it, so it doesn't really matter, but conceptually it still is
an unsigned char.

 Regards,
VZ