lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH] Add script allowing to install any wxWidgets version f


From: Greg Chicares
Subject: Re: [lmi] [PATCH] Add script allowing to install any wxWidgets version from Git
Date: Sat, 7 Apr 2018 19:06:13 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 2018-04-07 11:20, Vadim Zeitlin wrote:
> On Sat, 7 Apr 2018 09:35:02 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> I feel certain that I want a local mirror, and I imagine I want it to
> GC> contain "real" bare repositories.
> 
>  Yes, I think it's a better idea in the long term, I just was trying to say
> that you could test this quickly even without creating them right now.

That reassurance is good to hear.

> GC> Let's take libpng as an example.
> GC> - Do I mirror "git://git.code.sf.net/p/libpng/code"? Or does wx git
> GC>   contain its own libpng git repository that I can mirror instead?
> 
>  It's the latter and the URL is in .gitmodules file (this is what it's
> for!):
> 
>       $ git config -f .gitmodules submodule.src/png.url
>       https://github.com/wxWidgets/libpng.git

Then that's my problem--'.gitmodules' is not there:

/opt/lmi/third_party/src/wxWidgets[0]$git status
HEAD detached at 41045df7ea
Untracked files:
[...just my (untracked) build directory...]
/opt/lmi/third_party/src/wxWidgets[0]$git config -f .gitmodules 
submodule.src/png.url || echo "Failed"
Failed

This problem is not observed with a clone I created a month ago:

/tmp/wxw/wxWidgets[0]$ls -l /tmp/wxw/ 
total 4
drwxr-xr-x 19 greg greg 4096 Mar  9 13:17 wxWidgets
/tmp/wxw/wxWidgets[0]$ls -a -d .git*  
.git  .gitattributes  .github  .gitignore  .gitmodules
/tmp/wxw/wxWidgets[0]$git config -f .gitmodules submodule.src/png.url
https://github.com/wxWidgets/libpng.git

But in both cases I cloned the same repository, successfully,
the same simple way in both cases:
  git clone some_url some_subdirectory
so the difference must be due to the version checked out:

/opt/lmi/third_party/src/wxWidgets[0]$git log -1
commit 41045df7ea5f93e4c07c1bd846d7127a372705bd (HEAD)
Author: Vadim Zeitlin <address@hidden>
Date:   2017-02-20T14:55:47+00:00

/tmp/wxw/wxWidgets[0]$git log -1
commit 6037718fef803a16e655135885bd2603f35c938d (HEAD -> master, origin/master, 
origin/HEAD)
Author: Vadim Zeitlin <address@hidden>
Date:   2018-03-08T22:20:05+00:00

> GC> I ran './install_wx.sh' before PR #80, which executed this line:
> GC>   git clone "$wx_git_url" ${wx_dir##*/}
> GC> and I ran
> GC>   wx_skip_clean=1 ./install_wx.sh
> GC> after applying PR #80. Now the clone is up to date:
> GC>   /opt/lmi/third_party/src/wxWidgets[0]$git rev-parse HEAD                
>            
> GC>   41045df7ea5f93e4c07c1bd846d7127a372705bd
> GC> and, if I understand the 'skip_update' logic correctly, there's
> GC> nothing more that the script should do--the new PR #80 section
> GC> is skipped. If that's right, then I should have all the submodules
> GC> I need. But I seem to have none, because there's no '.gitmodules':
> GC>   /opt/lmi/third_party/src/wxWidgets[0]$ls -a .git/       
> GC>   .  ..  HEAD  branches  config  description  hooks  index  info  logs  
> objects  packed-refs  refs
> 
>  It's not under .git, but in the repository itself, however...

Okay, I see it there in my up-to-date clone.

> GC> And I had hoped that maybe wxWidgets/src/png would contain its
> GC> own '.git' subdirectory, but it doesn't. Is this merely because
> GC> 41045df7ea didn't yet use submodules?
> 
> .. you wouldn't find .gitmodules even in the repository root in this
> commit because submodules hadn't been used then yet:
> 
>       % git show 41045df7ea:.gitmodules
>       fatal: Path '.gitmodules' exists on disk, but not in '41045df7ea'.
> 
>  If you rerun the script now using a later commit, e.g.
> wx_commit_sha=379a404f9804ac044df44f18907e192917fec8aa (this is v3.1.1),
> it should initialize all the submodules. If you don't set up wx_git_url to
> point to a local mirror, it will get them from GitHub, i.e., again, it will
> take some time to do it -- but it should still work.

I'll do that. It'll take a few minutes, but that's okay: I should
test a full install with the latest script anyway, before asking
Kim to try it on a tiny laptop behind a corporate firewall.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]