lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Branching to replace XSL-FO


From: Greg Chicares
Subject: Re: [lmi] Branching to replace XSL-FO
Date: Mon, 9 Oct 2017 15:59:31 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 2017-10-06 21:51, Vadim Zeitlin wrote:
> On Fri, 6 Oct 2017 20:53:37 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> $ git checkout vz-no-xslfo
> GC> $ make srcdir=/opt/lmi/src/lmi -f /opt/lmi/src/lmi/GNUmakefile 
> check_concinnity 2>&1 |less -S
> GC> 
> GC> If you haven't addressed the output yourself yet,
> 
>  I planned to do it as part of my final review but I indeed haven't done
> this yet. I can/will do it soon, but probably not before Monday.

Okay, then let me just offer a few comments.

I want to maintain the 31-character limit on file names. Do we really need
to use nine of those characters for '.mustache', or would it be better to
use a shorter extension? For 'ctemplate', '.tpl' is suggested here:
  https://github.com/OlafvdSpek/ctemplate/blob/master/contrib/highlighting.vim
| autodetects file with tpl extension
and '.hbs' has been used for 'handlebars'.

Mustache files should all contain a boilerplate copyright notice.

'compliance_tracking_number.mustache': Let's replace the base name of
this file with 'imprimatur'.

'reg_d_individual_cur_irr.mustache' vs. 'reg_d_individual_guar_irr.mustache':
Let's use 'guar_' as above and 'curr_' with two r's, to follow the
convention used elsewhere in lmi.

Will you rebase the final result on current lmi master?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]