Re: [lmi] [PATCH] Add --gui_test_path command line option to the GUI test.

[Greg Chicares]

On 2014-12-15 15:56, Vadim Zeitlin wrote:
> On Mon, 15 Dec 2014 15:40:20 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> I'm thinking of the new developer who downloads the sources, builds the
> GC> code, and runs the tests--without any /opt/lmi/gui_test/ directory, and
> GC> without the (potentially proprietary) test files it contains. In that 
> case,
> GC> I'd like the other tests to run smoothly, without any scary messagebox.
> GC> Could you therefore change the messagebox to a reassuring text message on
> GC> stdout? Let's say:
> GC> 
> GC> << "Optional extra tests would be run if any were found in '"
> GC> << test_files_path_.native_file_string()
> GC> << ", but no such directory exists. Proceeding to run built-in tests."
> 
>  This can be done easily, of course, but this message wouldn't be totally
> correct, at least not right now. If the code remains otherwise unchanged,
> we'd simply use the current working directory instead of /opt/lmi/gui_test
> and look in this directory for the miscellaneous input files and if they
> are really not there the tests would fail instead of just not being run.
> 
>  Granted, this will probably change soon as at least InputSequences.cns and
> PasteCensus.cns will disappear completely. I'm not sure about the remaining
> ones though: will CoiMultiplier.cns, MonthlyTrace.ill and MecTesting.mec be
> not needed neither any longer? If so, I prefer to update the code using all
> these files first and then just make the change proposed above.

Okay, let's wait until I've had a chance to address those other matters.
I believe that at least some of those files will go away, but the
shortest path to the goal is for me to finish the specifications for
the few files that remain; then I'll raise this question again when we
have that documentation written.