Re: [lmi] PATCH: fix "--help" for the GUI test

[Greg Chicares]

On 2014-12-05 22:56Z, Vadim Zeitlin wrote:
> On Thu, 04 Dec 2014 02:55:34 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> Well, you know this stuff far better than I do; I'd welcome a patch.
> 
>  Here is the trivial one doing it for both the main executable and the
> test.

Committed 20141206T1915Z, revision 6050.

> However it doesn't address the problem of the warning [correctly]
> given when encountering an unrecognized command line option still being
> "untimely". I think the above mentioned condition in alert_wx.cpp should be
> simply removed to fix this. Just in case you agree, I also attach a[n even
> more trivial] patch doing this as well.

Committed 20141206T2004Z, revision 6051.

This seemed trivial to you because you had just done the hard work in wx.
What it actually means is that no wxMessageBox can be "untimely" any more.
This is a really nice change.

This command
  grep Untimely *.?pp
still finds one match; do you think that occurrence should be changed
e.g. as follows?

 void fatal_error_alert(std::string const& s)
 {
-    if(!wxTheApp)
-        {
-        safely_show_message("Untimely error message:\n" + s);
-        }
     throw std::runtime_error(s);
 }

I haven't thought it through carefully, so I'm not sure it's trivial.