Re: [lmi] fix compilation with wx-2.8 compatibility disabled

[Vadim Zeitlin]

On Sun, 23 Feb 2014 00:53:50 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2014-02-03 15:06Z, Václav Slavík wrote:
GC> 
GC> >      // 100 is the default minimal size of a widget - taken from wx 
headers.
GC> > -    int width  = std::max(self->GetRowLabelSize() + 
self->GetColumnWidth(0), 100);
GC> > +    int width  = std::max(self->GetRowLabelSize() + self->GetColSize(0), 
100);
GC> >      int height = std::max(self->GetColLabelSize() + 
self->GetRowHeight(0), 100);
GC> 
GC> I somewhat expected that GetRowHeight() would have to change to
GC> GetRowSize(). But it doesn't matter--if such a change is needed
GC> for wx-3.0, that will become apparent soon enough.

 No, it isn't needed, somehow GetRowHeight() has never been deprecated and
we can't remove it without deprecating it first, so in the worst (best?)
case we'd deprecate it now and remove it in wxWidgets 3.6, i.e. not any
time soon. But perhaps it would still be better to use GetRowSize() (which
does exist) just for consistency.

 Regards,
VZ