Re: [lmi] [PATCH 1/2] Make InputSequenceEntry friendly to embedding in wxDVC.

[Vadim Zeitlin]

On Tue, 09 Aug 2011 11:40:51 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2011-08-09 09:41Z, Vadim Zeitlin wrote:
GC> > On Tue, 9 Aug 2011 11:16:03 +0200 Václav Slavík <address@hidden> wrote:
GC> > 
GC> > VS> On 8 Aug 2011, at 20:26, Greg Chicares wrote:
GC> > VS> > I'd really like to hear the answer, too--AFAICT, 
TransferDataFromWindow()
GC> > VS> > shouldn't be called by wx (or at least by wxmsw) unless an Apply 
button
GC> > VS> > is pressed or AcceptAndClose() is called.
GC> > VS> 
GC> > VS> The answer lies in LMI's MvcController::UponUpdateUI(), which is 
called
GC> > VS> at idle time and calls TransferDataFromWindow():
GC> > 
GC> >  Indeed, I can now see it as well
GC> 
GC> Me too, now that you point it out. I was staring at it yesterday--it's the 
only
GC> place lmi calls TransferDataFromWindow()--but, even though the tabbed-dialog
GC> .xrc files specify wxWS_EX_VALIDATE_RECURSIVELY, I didn't imagine it would
GC> recurse into a pop-up dialog.

 I've been reviewing the wxWidgets-related TODO items and found this
message among them, so I'd just like to say that in the upcoming wxWidgets
3.0, neither of TransferData{From,To}Window() and Validate() recurses into
the child windows any more (and this was already the case in 2.9.5 and
possibly even 2.9.4, although I'd have to look this up to be certain).

 So the original Vaclav's patch from the beginning of this thread[*] can be
finally safely applied now.

 Regards,
VZ

[*] this thread: http://lists.nongnu.org/archive/html/lmi/2011-06/msg00056.html