Re: [lmi] Skeleton::InitIcon() cleanup

[Vaclav Slavik]

On Tue, 2009-03-31 at 02:54 +0000, Greg Chicares wrote:
> (2) requires wx-2.9, but we're using wx-2.8.10 in production.

That's only because it relies on newly added default value for the
'type' parameter. Sorry about, I forgot I only added it on the trunk.

> http://cvs.savannah.gnu.org/viewvc/lmi/lmi/main_wx.cpp?r1=1.133&r2=1.134

Or you could explicitly use 2.9's default to be compatible with 2.8:
        wxIconBundle(AddDataDir("lmi.ico"), wxBITMAP_TYPE_ANY)
is equivalent to
        wxIconBundle(AddDataDir("lmi.ico"))
on the trunk and behaves identically to trunk version in 2.8.

But the best would be to always use the 2.8 version:
        wxIconBundle(AddDataDir("lmi.ico"), wxBITMAP_TYPE_ICO)
That's what I should have done to begin with, it's a bit more efficient
than wxBITMAP_TYPE_ANY.

Regards,
Vaclav